Janus007/Calendar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactors resize and position utility handling

Browse source 
Extracts position calculation logic into a separate utility class

Introduces PositionUtils to centralize pixel and minute conversion methods
Removes redundant calculation methods from ResizeHandleManager
Updates Configuration to include default API endpoint

Simplifies resize and height management across components
This commit is contained in:
Janus C. H. Knudsen 2025-11-05 21:53:08 +01:00
parent a1bee99d8e
commit 202074e391
3 changed files with 11 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/managers/ResizeHandleManager.ts
View file

@ -2,6 +2,7 @@ import { eventBus } from '../core/EventBus';
import { CoreEvents } from '../constants/CoreEvents';
import { Configuration } from '../configurations/CalendarConfig';
import { IResizeEndEventPayload } from '../types/EventTypes';
import { PositionUtils } from '../utils/PositionUtils';
type SwpEventEl = HTMLElement & { updateHeight?: (h: number) => void };
@ -18,7 +19,6 @@ export class ResizeHandleManager {
private startDurationMin = 0;
private direction: 'grow' | 'shrink' = 'grow';
private hourHeightPx: number;
private snapMin: number;
private minDurationMin: number;
private animationId: number | null = null;
@ -30,11 +30,12 @@ export class ResizeHandleManager {
private pointerCaptured = false;
private prevZ?: string;
private config: Configuration;
private positionUtils: PositionUtils;
constructor(config: Configuration) {
constructor(config: Configuration, positionUtils: PositionUtils) {
this.config = config;
this.positionUtils = positionUtils;
const grid = this.config.gridSettings;
this.hourHeightPx = grid.hourHeight;
this.snapMin = grid.snapInterval;
this.minDurationMin = this.snapMin; // Use snap interval as minimum duration
}
@ -53,19 +54,6 @@ export class ResizeHandleManager {
this.unsubscribers.forEach(u => u());
}
private minutesPerPx(): number {
return 60 / this.hourHeightPx;
}
private pxFromMinutes(min: number): number {
return (min / 60) * this.hourHeightPx;
}
private roundSnap(min: number, dir: 'grow' | 'shrink'): number {
const q = min / this.snapMin;
return (dir === 'grow' ? Math.ceil(q) : Math.floor(q)) * this.snapMin;
}
private refreshEventCache(): void {
this.cachedEvents = Array.from(
document.querySelectorAll<SwpEventEl>('swp-day-columns swp-event')
@ -167,7 +155,7 @@ export class ResizeHandleManager {
const startHeight = el.offsetHeight;
this.startDurationMin = Math.max(
this.minDurationMin,
Math.round(startHeight * this.minutesPerPx())
Math.round(this.positionUtils.pixelsToMinutes(startHeight))
);
this.prevZ = (el.closest<HTMLElement>('swp-event-group') ?? el).style.zIndex;
@ -193,9 +181,9 @@ export class ResizeHandleManager {
this.direction = dy >= 0 ? 'grow' : 'shrink';
// Calculate raw height from pixel delta (no snapping - 100% smooth like drag & drop)
const startHeight = this.pxFromMinutes(this.startDurationMin);
const startHeight = this.positionUtils.minutesToPixels(this.startDurationMin);
const rawHeight = startHeight + dy;
const minHeight = this.pxFromMinutes(this.minDurationMin);
const minHeight = this.positionUtils.minutesToPixels(this.minDurationMin);
this.targetHeight = Math.max(minHeight, rawHeight); // Raw height, no snap
@ -228,9 +216,9 @@ export class ResizeHandleManager {
// Snap to grid on pointer up (like DragDropManager does on mouseUp)
const currentHeight = this.targetEl.offsetHeight;
const snapDistancePx = this.pxFromMinutes(this.snapMin);
const snapDistancePx = this.positionUtils.minutesToPixels(this.snapMin);
const snappedHeight = Math.round(currentHeight / snapDistancePx) * snapDistancePx;
const minHeight = this.pxFromMinutes(this.minDurationMin);
const minHeight = this.positionUtils.minutesToPixels(this.minDurationMin);
const finalHeight = Math.max(minHeight, snappedHeight) - 3; // lille gap til grid-linjer
this.targetEl.updateHeight?.(finalHeight);