Janus007/Calendar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactors dependency injection and configuration management

Browse source 
Replaces global singleton configuration with dependency injection
Introduces more modular and testable approach to configuration
Removes direct references to calendarConfig in multiple components
Adds explicit configuration passing to constructors

Improves code maintainability and reduces global state dependencies
This commit is contained in:
Janus C. H. Knudsen 2025-10-30 23:47:30 +01:00
parent fb48e410ea
commit 8bbb2f05d3
30 changed files with 365 additions and 559 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/elements/SwpEventElement.ts
View file

@ -1,5 +1,5 @@
import { CalendarEvent } from '../types/CalendarTypes';
import { calendarConfig } from '../core/CalendarConfig';
import { CalendarConfig } from '../core/CalendarConfig';
import { TimeFormatter } from '../utils/TimeFormatter';
import { PositionUtils } from '../utils/PositionUtils';
import { DateService } from '../utils/DateService';
@ -9,11 +9,13 @@ import { DateService } from '../utils/DateService';
*/
export abstract class BaseSwpEventElement extends HTMLElement {
protected dateService: DateService;
protected config: CalendarConfig;
constructor() {
super();
const timezone = calendarConfig.getTimezone?.();
this.dateService = new DateService(timezone);
// TODO: Find better solution for web component DI
this.config = new CalendarConfig();
this.dateService = new DateService(this.config);
}
// ============================================
@ -135,7 +137,7 @@ export class SwpEventElement extends BaseSwpEventElement {
this.style.height = `${newHeight}px`;
// 2. Calculate new end time based on height
const gridSettings = calendarConfig.getGridSettings();
const gridSettings = this.config.getGridSettings();
const { hourHeight, snapInterval } = gridSettings;
// Get current start time
@ -228,7 +230,7 @@ export class SwpEventElement extends BaseSwpEventElement {
* Calculate start/end minutes from Y position
*/
private calculateTimesFromPosition(snappedY: number): { startMinutes: number; endMinutes: number } {
const gridSettings = calendarConfig.getGridSettings();
const gridSettings = this.config.getGridSettings();
const { hourHeight, dayStartHour, snapInterval } = gridSettings;
// Get original duration
@ -258,8 +260,8 @@ export class SwpEventElement extends BaseSwpEventElement {
*/
public static fromCalendarEvent(event: CalendarEvent): SwpEventElement {
const element = document.createElement('swp-event') as SwpEventElement;
const timezone = calendarConfig.getTimezone?.();
const dateService = new DateService(timezone);
const config = new CalendarConfig();
const dateService = new DateService(config);
element.dataset.eventId = event.id;
element.dataset.title = event.title;
@ -333,8 +335,8 @@ export class SwpAllDayEventElement extends BaseSwpEventElement {
*/
public static fromCalendarEvent(event: CalendarEvent): SwpAllDayEventElement {
const element = document.createElement('swp-allday-event') as SwpAllDayEventElement;
const timezone = calendarConfig.getTimezone?.();
const dateService = new DateService(timezone);
const config = new CalendarConfig();
const dateService = new DateService(config);
element.dataset.eventId = event.id;
element.dataset.title = event.title;