Refactors dependency injection and configuration management

Replaces global singleton configuration with dependency injection
Introduces more modular and testable approach to configuration
Removes direct references to calendarConfig in multiple components
Adds explicit configuration passing to constructors

Improves code maintainability and reduces global state dependencies
This commit is contained in:
Janus C. H. Knudsen 2025-10-30 23:47:30 +01:00
parent fb48e410ea
commit 8bbb2f05d3
30 changed files with 365 additions and 559 deletions

View file

@ -1,6 +1,6 @@
import { EventBus } from '../core/EventBus';
import { CalendarView, IEventBus } from '../types/CalendarTypes';
import { calendarConfig } from '../core/CalendarConfig';
import { CalendarConfig } from '../core/CalendarConfig';
import { CoreEvents } from '../constants/CoreEvents';
/**
@ -9,17 +9,19 @@ import { CoreEvents } from '../constants/CoreEvents';
*/
export class ViewManager {
private eventBus: IEventBus;
private config: CalendarConfig;
private currentView: CalendarView = 'week';
private buttonListeners: Map<Element, EventListener> = new Map();
// Cached DOM elements for performance
private cachedViewButtons: NodeListOf<Element> | null = null;
private cachedWorkweekButtons: NodeListOf<Element> | null = null;
private lastButtonCacheTime: number = 0;
private readonly CACHE_DURATION = 5000; // 5 seconds
constructor(eventBus: IEventBus) {
constructor(eventBus: IEventBus, config: CalendarConfig) {
this.eventBus = eventBus;
this.config = config;
this.setupEventListeners();
}
@ -140,13 +142,13 @@ export class ViewManager {
*/
private changeWorkweek(workweekId: string): void {
// Update the calendar config (does not emit events)
calendarConfig.setWorkWeek(workweekId);
this.config.setWorkWeek(workweekId);
// Update button states using cached elements
this.updateAllButtons();
// Emit workweek change event with full payload
const settings = calendarConfig.getWorkWeekSettings();
const settings = this.config.getWorkWeekSettings();
this.eventBus.emit(CoreEvents.WORKWEEK_CHANGED, {
workWeekId: workweekId,
settings: settings
@ -166,7 +168,7 @@ export class ViewManager {
this.updateButtonGroup(
this.getWorkweekButtons(),
'data-workweek',
calendarConfig.getCurrentWorkWeek()
this.config.getCurrentWorkWeek()
);
}