Janus007/Calendar
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactors dependency injection and configuration management

Browse source 
Replaces global singleton configuration with dependency injection
Introduces more modular and testable approach to configuration
Removes direct references to calendarConfig in multiple components
Adds explicit configuration passing to constructors

Improves code maintainability and reduces global state dependencies
This commit is contained in:
Janus C. H. Knudsen 2025-10-30 23:47:30 +01:00
parent fb48e410ea
commit 8bbb2f05d3
30 changed files with 365 additions and 559 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/renderers/GridStyleManager.ts
View file

@ -1,4 +1,4 @@
import { calendarConfig } from '../core/CalendarConfig';
import { CalendarConfig } from '../core/CalendarConfig';
import { ResourceCalendarData } from '../types/CalendarTypes';
interface GridSettings {
@ -16,7 +16,10 @@ interface GridSettings {
* Separated from GridManager to follow Single Responsibility Principle
*/
export class GridStyleManager {
constructor() {
private config: CalendarConfig;
constructor(config: CalendarConfig) {
this.config = config;
}
/**
@ -24,9 +27,9 @@ export class GridStyleManager {
*/
public updateGridStyles(resourceData: ResourceCalendarData | null = null): void {
const root = document.documentElement;
const gridSettings = calendarConfig.getGridSettings();
const gridSettings = this.config.getGridSettings();
const calendar = document.querySelector('swp-calendar') as HTMLElement;
const calendarType = calendarConfig.getCalendarMode();
const calendarType = this.config.getCalendarMode();
// Set CSS variables for time and grid measurements
this.setTimeVariables(root, gridSettings);
@ -66,9 +69,9 @@ export class GridStyleManager {
if (calendarType === 'resource' && resourceData) {
return resourceData.resources.length;
} else if (calendarType === 'date') {
const dateSettings = calendarConfig.getDateViewSettings();
const workWeekSettings = calendarConfig.getWorkWeekSettings();
const dateSettings = this.config.getDateViewSettings();
const workWeekSettings = this.config.getWorkWeekSettings();
switch (dateSettings.period) {
case 'day':
return 1;
@ -80,8 +83,8 @@ export class GridStyleManager {
return workWeekSettings.totalDays;
}
}
return calendarConfig.getWorkWeekSettings().totalDays; // Default to work week
return this.config.getWorkWeekSettings().totalDays; // Default to work week
}
/**